HEX
Server: Apache/2.4.41 (Ubuntu)
System: Linux vmi1674223.contaboserver.net 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64
User: root (0)
PHP: 7.4.3-4ubuntu2.22
Disabled: pcntl_alarm,pcntl_fork,pcntl_waitpid,pcntl_wait,pcntl_wifexited,pcntl_wifstopped,pcntl_wifsignaled,pcntl_wifcontinued,pcntl_wexitstatus,pcntl_wtermsig,pcntl_wstopsig,pcntl_signal,pcntl_signal_get_handler,pcntl_signal_dispatch,pcntl_get_last_error,pcntl_strerror,pcntl_sigprocmask,pcntl_sigwaitinfo,pcntl_sigtimedwait,pcntl_exec,pcntl_getpriority,pcntl_setpriority,pcntl_async_signals,pcntl_unshare,
Upload Files
File: //opt/openproject/spec/controllers/types_controller_spec.rb
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) 2012-2020 the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2017 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
#
# See docs/COPYRIGHT.rdoc for more details.
#++

require 'spec_helper'

describe TypesController, type: :controller do
  let(:project) do
    FactoryBot.create(:project,
                       work_package_custom_fields: [custom_field_2])
  end
  let(:custom_field_1) do
    FactoryBot.create(:work_package_custom_field,
                       field_format: 'string',
                       is_for_all: true)
  end
  let(:custom_field_2) { FactoryBot.create(:work_package_custom_field) }
  let(:status_0) { FactoryBot.create(:status) }
  let(:status_1) { FactoryBot.create(:status) }

  context 'with an unauthorized account' do
    let(:current_user) { FactoryBot.create(:user) }

    before do
      allow(User).to receive(:current).and_return(current_user)
    end

    describe 'GET index' do
      describe 'the access should be restricted' do
        before { get 'index' }

        it { expect(response.status).to eq(403) }
      end
    end

    describe 'GET new' do
      describe 'the access should be restricted' do
        before { get 'new' }

        it { expect(response.status).to eq(403) }
      end
    end

    describe 'GET edit' do
      describe 'the access should be restricted' do
        before { get 'edit', params: { id: '123' } }

        it { expect(response.status).to eq(403) }
      end
    end

    describe 'POST create' do
      describe 'the access should be restricted' do
        before { post 'create' }

        it { expect(response.status).to eq(403) }
      end
    end

    describe 'DELETE destroy' do
      describe 'the access should be restricted' do
        before { delete 'destroy', params: { id: '123' } }

        it { expect(response.status).to eq(403) }
      end
    end

    describe 'POST update' do
      describe 'the access should be restricted' do
        before { post 'update', params: { id: '123' } }

        it { expect(response.status).to eq(403) }
      end
    end

    describe 'POST move' do
      describe 'the access should be restricted' do
        before { post 'move', params: { id: '123' } }

        it { expect(response.status).to eq(403) }
      end
    end
  end

  context 'with an authorized account' do
    let(:current_user) { FactoryBot.create(:admin) }

    before do
      allow(User).to receive(:current).and_return(current_user)
    end

    describe 'GET index' do
      before { get 'index' }
      it { expect(response).to be_successful }
      it { expect(response).to render_template 'index' }
    end

    describe 'GET new' do
      before { get 'new' }
      it { expect(response).to be_successful }
      it { expect(response).to render_template 'new' }
    end

    describe 'POST create' do
      describe 'WITH valid params' do
        let(:params) do
          { 'type' => { name: 'New type',
                        project_ids: { '1' => project.id },
                        custom_field_ids: { '1' => custom_field_1.id,
                                            '2' => custom_field_2.id } } }
        end

        before do
          post :create, params: params
        end

        it { expect(response).to be_redirect }
        it do
          type = ::Type.find_by(name: 'New type')
          expect(response).to redirect_to(action: 'edit', tab: 'settings', id: type.id)
        end
      end

      describe 'WITH an empty name' do
        render_views
        let(:params) do
          { 'type' => { name: '',
                        project_ids: { '1' => project.id },
                        custom_field_ids: { '1' => custom_field_1.id,
                                            '2' => custom_field_2.id } } }
        end

        before do
          post :create, params: params
        end

        it { expect(response.status).to eq(200) }
        it 'should show an error message' do
          expect(response.body).to have_content("Name can't be blank")
        end
      end

      describe 'WITH workflow copy' do
        let!(:existing_type) { FactoryBot.create(:type, name: 'Existing type') }
        let!(:workflow) do
          FactoryBot.create(:workflow,
                             old_status: status_0,
                             new_status: status_1,
                             type_id: existing_type.id)
        end

        let(:params) do
          { 'type' => { name: 'New type',
                        project_ids: { '1' => project.id },
                        custom_field_ids: { '1' => custom_field_1.id, '2' => custom_field_2.id } },
            'copy_workflow_from' => existing_type.id }
        end

        before do
          post :create, params: params
        end

        it { expect(response).to be_redirect }
        it do
          type = ::Type.find_by(name: 'New type')
          expect(response).to redirect_to(action: 'edit', tab: 'settings', id: type.id)
        end
        it 'should have the copied workflows' do
          expect(::Type.find_by(name: 'New type')
                        .workflows.count).to eq(existing_type.workflows.count)
        end
      end
    end

    describe 'GET edit settings' do
      render_views
      let(:type) do
        FactoryBot.create(:type, name: 'My type',
                                  is_milestone: true,
                                  projects: [project])
      end

      before do
        get 'edit', params: { id: type.id, tab: :settings }
      end

      it { expect(response).to be_successful }
      it { expect(response).to render_template 'edit' }
      it { expect(response).to render_template 'types/form/_settings' }
      it { expect(response.body).to have_selector "input[@name='type[name]'][@value='My type']" }
      it { expect(response.body).to have_selector "input[@name='type[is_milestone]'][@value='1'][@checked='checked']" }
    end

    describe 'GET edit projects' do
      render_views
      let(:type) do
        FactoryBot.create(:type, name: 'My type',
                                  is_milestone: true,
                                  projects: [project])
      end

      before do
        get 'edit', params: { id: type.id, tab: :projects }
      end

      it { expect(response).to be_successful }
      it { expect(response).to render_template 'edit' }
      it { expect(response).to render_template 'types/form/_projects' }
      it { expect(response.body).to have_selector "input[@name='type[project_ids][]'][@value='#{project.id}'][@checked='checked']" }
    end

    describe 'POST update' do
      let(:project2) { FactoryBot.create(:project) }
      let(:type) do
        FactoryBot.create(:type, name: 'My type',
                                  is_milestone: true,
                                  projects: [project, project2])
      end

      describe 'WITH type rename' do
        let(:params) do
          { 'id' => type.id,
            'type' => { name: 'My type renamed' },
            'tab' => "settings" }
        end

        before do
          put :update, params: params
        end

        it { expect(response).to be_redirect }
        it do
          expect(response).to(
            redirect_to(edit_type_tab_path(id: type.id, tab: "settings"))
          )
        end
        it 'should be renamed' do
          expect(::Type.find_by(name: 'My type renamed').id).to eq(type.id)
        end
      end

      describe 'WITH projects removed' do
        let(:params) do
          { 'id' => type.id,
            'type' => { project_ids: [''] },
            'tab' => "projects" }
        end

        before do
          put :update, params: params
        end

        it { expect(response).to be_redirect }
        it do
          expect(response).to(
            redirect_to(edit_type_tab_path(id: type.id, tab: :projects))
          )
        end
        it 'should have no projects assigned' do
          expect(::Type.find_by(name: 'My type').projects.count).to eq(0)
        end
      end
    end

    describe 'POST move' do
      let!(:type) { FactoryBot.create(:type, name: 'My type', position: '1') }
      let!(:type2) { FactoryBot.create(:type, name: 'My type 2', position: '2') }
      let(:params) { { 'id' => type.id, 'type' => { move_to: 'lower' } } }

      before do
        post :move, params: params
      end

      it { expect(response).to be_redirect }
      it { expect(response).to redirect_to(types_path) }
      it 'should have the position updated' do
        expect(::Type.find_by(name: 'My type').position).to eq(2)
      end
    end

    describe 'DELETE destroy' do
      let(:type) { FactoryBot.create(:type, name: 'My type') }
      let(:type2) { FactoryBot.create(:type, name: 'My type 2', projects: [project]) }
      let(:type3) { FactoryBot.create(:type, name: 'My type 3', is_standard: true) }

      describe 'successful detroy' do
        let(:params) { { 'id' => type.id } }

        before do
          delete :destroy, params: params
        end

        it { expect(response).to be_redirect }
        it { expect(response).to redirect_to(types_path) }
        it 'should have a successful destroy flash' do
          expect(flash[:notice]).to eq(I18n.t(:notice_successful_delete))
        end
        it 'should not be present in the database' do
          expect(::Type.find_by(name: 'My type')).to eq(nil)
        end
      end

      describe 'detroy type in use should fail' do
        let(:project2) do
          FactoryBot.create(:project,
                             work_package_custom_fields: [custom_field_2],
                             types: [type2])
        end
        let!(:work_package) do
          FactoryBot.create(:work_package,
                             author: current_user,
                             type: type2,
                             project: project2)
        end
        let(:params) { { 'id' => type2.id } }

        before do
          delete :destroy, params: params
        end

        it { expect(response).to be_redirect }
        it { expect(response).to redirect_to(types_path) }
        it 'should show an error message' do
          expect(flash[:error]).to eq(I18n.t(:error_can_not_delete_type))
        end
        it 'should be present in the database' do
          expect(::Type.find_by(name: 'My type 2').id).to eq(type2.id)
        end
      end

      describe 'destroy standard type should fail' do
        let(:params) { { 'id' => type3.id } }

        before { delete :destroy, params: params }

        it { expect(response).to be_redirect }
        it { expect(response).to redirect_to(types_path) }
      end
    end
  end
end